Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene unique nodes: clarify intended usage #6670

Merged
merged 6 commits into from
Feb 24, 2023

Conversation

31
Copy link
Contributor

@31 31 commented Jan 25, 2023

Update scene unique nodes doc to clarify what it is meant for, what it can't do, and some alternatives.

I wasn't able to find much official info about this feature other than the implementation PR and a couple release notes articles. I think it's worth bringing it into the actual docs:

I also made some subjective edits that remove some ambiguity and I think make the doc read more naturally.

Bugsquad edit:

@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jan 25, 2023
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall direction is good, but I have a few suggestions and some formatting corrections.

tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
tutorials/scripting/scene_unique_nodes.rst Outdated Show resolved Hide resolved
31 and others added 4 commits January 28, 2023 15:29
Co-authored-by: Yuri Sizov <11782833+YuriSizov@users.noreply.github.com>
Apply suggestions.

Rework intro.

Remove some elaboration on same-scene behavior.

Remove Groups example.
@31 31 requested a review from YuriSizov January 29, 2023 08:00
@YuriSizov YuriSizov merged commit a9ed49e into godotengine:master Feb 24, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@31 31 deleted the dev/31/sceneunique branch February 25, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C# Error with Unique Node - returns always null
3 participants